From 9c6d1ffa3af180b470c6b1d086a02c94f9a0625c Mon Sep 17 00:00:00 2001 From: Jan Pazdziora Date: Wed, 8 Mar 2023 15:54:55 +0100 Subject: [PATCH] The fatal behaviour was removed from v2.39.0-rc0-2-g2ad150e35e so it was likely never important. --- t/20-simple.t | 19 ------------------- 1 file changed, 19 deletions(-) diff --git a/t/20-simple.t b/t/20-simple.t index 013383a..941b4c6 100644 --- a/t/20-simple.t +++ b/t/20-simple.t @@ -74,25 +74,6 @@ $r->run( add => 'readme.txt' ); # unset all editors delete @ENV{qw( EDITOR VISUAL GIT_EDITOR )}; -SKIP: { - BEGIN { $tests += 2 } - skip "these tests require git >= 1.6.6, but we only have $version", 2 - if Git::Repository->version_lt('1.6.6'); - - skip "editor defined directly in .gitconfig", 2 - if $r->run( config => 'core.editor' ); - - skip "this test does not work with msysgit on Win32", 2 - if $^O eq 'MSWin32'; - - ok( !eval { $r->run( var => 'GIT_EDITOR' ); 1; }, 'git var GIT_EDITOR' ); - like( - $@, - qr/^fatal: Terminal is dumb, but EDITOR unset /, - 'Git complains about lack of smarts and editor' - ); -} - # with git commit it's not fatal BEGIN { $tests += 4 } SKIP: {